Differences

This shows you the differences between two versions of the page.

Link to this comparison view

irc:1489878000 [2017/05/27 13:44] (current)
Line 1: Line 1:
 +[00:45:33] <​AlexLehm>​ yunyul: depends on the route path probably
 +
 +[09:53:38] *** ChanServ sets mode: +o temporalfox
 +
 +[12:28:31] *** ChanServ sets mode: +o purplefox
 +
 +[12:38:57] <​ivanovdns>​ Hi there! Could someone please help with pushing a pull request to the primary vertx-web repo. I did this: https://​github.com/​ivanovdns/​vertx-web/​commit/​ba4f62b76844d261890e6708deb062a34130757f and not sure that my fix will pass through your tests..
 +
 +[12:39:39] <​ivanovdns>​ IDEA fails template tests 'cause some file were not exists in repo.. but yours jenkins said OK..
 +
 +[12:41:06] <​ivanovdns>​ please don't hesitate to rub my nose in my mistakes
 +
 +[12:42:59] <​ivanovdns>​ I can pull request to the primary repo if it more convenient for administrators..
 +
 +[13:30:04] <​AlexLehm>​ ivanovdns: i can set up a jenkins job for your branch, if you want to do a pull request, someone from the code devs can probably review it
 +
 +[13:50:46] <​AlexLehm>​ oops
 +
 +[20:27:20] *** ChanServ sets mode: +o temporal_
 +
 +[21:43:22] *** ChanServ sets mode: +o temporalfox
 +
 +[23:39:01] *** ChanServ sets mode: +o temporalfox
 +
 +[23:51:49] *** ChanServ sets mode: +o temporalfox