Differences

This shows you the differences between two versions of the page.

Link to this comparison view

irc:1473199200 [2017/05/27 13:44] (current)
Line 1: Line 1:
 +[10:19:05] <​temporalfox>​ AlexLehm hi
 +
 +[11:24:30] <​temporalfox>​ hi AlexLehm we can close this issue right https://​github.com/​eclipse/​vert.x/​issues/​1570 ?
 +
 +[11:26:59] <​AlexLehm>​ Hello Julien
 +
 +[11:27:13] <​AlexLehm>​ yes, the issue is fixed by netty 4.1.5
 +
 +[11:28:30] <​AlexLehm>​ forgot about the issue
 +
 +[11:36:59] <​AlexLehm>​ temporalfox:​ I have one minor thing that is open, but it is test only
 +
 +[11:38:54] <​AlexLehm>​ I marked a test as TODO since I think it doesn'​t test anything, should I keep that in?
 +
 +[11:38:55] <​AlexLehm>​ https://​github.com/​eclipse/​vert.x/​blob/​17b58c22e857d1836de706159e4d848ee75b2417/​src/​test/​java/​io/​vertx/​test/​core/​NetTest.java#​L2225
 +
 +[12:04:20] <​AlexLehm>​ ah ok, the test fails if the hostname is not localhost, so it does makes sense even though its setting trustAll
 +
 +[12:04:30] <​AlexLehm>​ i will change the comment and remove the TODO
 +
 +[12:11:30] <​AlexLehm>​ https://​github.com/​eclipse/​vert.x/​pull/​1616
 +
 +[16:42:56] *** kornbluth.freenode.net sets mode: +o temporalfox
 +
 +[17:46:28] <​temporalfox>​ so let's stage this release
 +
 +[18:47:39] <​tsegismont>​ Go temporalfox go!
 +
 +[23:28:19] *** ChanServ sets mode: +o temporalfox