This version (2017/05/27 13:44) is a draft.
Approvals: 0/1

[12:25:51] <aesteve> hi purplefox , I'm afraid I faced another bug in redis-client that will be added to your huge pile of things to do

[12:25:53] <aesteve> https://github.com/vert-x3/vertx-redis-client/issues/9

[12:25:56] <aesteve> sorry :(

[12:59:54] <AlexLehm> purplefox: I have improved the tests a bit and changed the pool test that used a large mail to test

[16:19:10] <temporalfox> purplefox how are you doing ?

[16:19:36] <purplefox> not bad, and you?

[16:19:52] <purplefox> actually.. i am not feeling too great today, didn't get much sleep last night :(

[16:42:26] <rajith> purplefox: oops bad time to bug u then :)

[16:42:54] <rajith> purplefox: I'm sorting out some last min doc issues. But code wise and example wise the initial-work branch is good to go

[16:43:13] <rajith> purplefox: I will be adding more doc updates through out the day.

[16:43:45] <rajith> purplefox: could we get the code into master? Whether we want to include this in the upcoming milestone release is upto you :).

[16:44:41] <rajith> purplefox: but I think moving the code to master is a good idea so anyone in the community can now start trying it out as the code has gone through many bug fixes and the concept being reviewed based on the demos I did.

[16:59:03] <purplefox> rajith: once it's reviewed it can go into master :)

[16:59:20] <purplefox> temporalfox: can you review that apex pr?

[16:59:28] <temporalfox> I will

[16:59:29] <purplefox> ah i mean vertx-web! ;)

[16:59:35] <temporalfox> is there anything I should do beside that ?

[16:59:47] <temporalfox> I've been working on creating tests for the worker client/server

[16:59:49] <purplefox> are you stuck for things to do?

[16:59:59] <rajith> purplefox: I'm going to create a pull request as soon as I have the doc stuff completed. Hopefully in an hour or two

[17:00:06] <temporalfox> there is the build to look at a bit

[17:00:15] <purplefox> yeah the stack stuff is important

[17:00:20] <temporalfox> for instance vertx-web has issues because it needs an hardcoded python

[17:00:23] <rajith> purplefox: but given u are not feeling well and late in the day for you, pls have a look on monday

[17:00:27] <temporalfox> how do you run it ?

[17:00:54] <purplefox> do you mean the test suite?

[17:00:58] <temporalfox> at the moment it runs with

[17:00:58] <purplefox> i just use mvn test

[17:00:59] <temporalfox> p = Runtime.getRuntime().exec(“./venv/bin/python sockjs-protocol-0.3.3.py”, envp, dir);

[17:01:03] <temporalfox> this one

[17:01:06] <temporalfox> I think only works for you :-)

[17:01:29] <temporalfox> so that needs to be tweaked so it runs on jenkins and on other's machines

[17:02:27] <purplefox> weird i thought i added it to the git repo

[17:03:04] <temporalfox> is it a script ?

[17:03:10] <temporalfox> or a binary ?

[17:03:32] <purplefox> yes, it's in src/test/sockjs-protocol/venv

[17:03:40] <purplefox> that's the python environment

[17:03:57] <purplefox> so it should work afaict

[17:04:02] <purplefox> what error do you get?

[17:04:38] <purplefox> or maybe it's got linux specific stuff in there….

[17:07:02] <temporalfox> let me run it :-)

[17:07:59] <temporalfox> right now in master it does not compile for me

[17:08:05] <temporalfox> [ERROR] symbol: method isClusterable()

[17:08:31] <temporalfox> ah I think it's because of jenkins

[17:08:38] <temporalfox> for this error

[17:09:21] <purplefox> you want the user_session_handler branch

[17:09:29] <temporalfox> ok

[17:10:12] <temporalfox> java.io.IOException: Cannot run program “./venv/bin/python” (in directory “src/test/sockjs-protocol”): error=2, No such file or directory

[17:10:13] <temporalfox> at java.lang.UNIXProcess.forkAndExec(Native Method)

[17:10:20] <temporalfox> jenkins has the same failure

[17:10:20] <purplefox> is this really the first time you have run the apex test suite?

[17:10:24] <temporalfox> no

[17:10:30] <temporalfox> before it used to work

[17:10:37] <purplefox> ok

[17:10:42] <purplefox> do you have this directory?

[17:10:46] <temporalfox> for instance when I refactored the permission inbout to dataobject I ran it :-)

[17:10:52] <temporalfox> no

[17:10:59] <temporalfox> I htink it's because

[17:11:00] <purplefox> weird, it is in git repo

[17:11:01] <temporalfox> of “bin”

[17:11:13] <temporalfox> that is .gitignored

[17:11:18] <purplefox> ah!

[17:14:41] <purplefox> temporalfox: ok can you git pull?

[17:14:50] <purplefox> and try again

[17:19:53] <purplefox> temporalfox: any good?

[17:27:24] <temporalfox> one sec

[17:30:52] <temporalfox> they run now but

[17:30:58] <temporalfox> I get

[17:31:03] <temporalfox> Protocol tests failed expected:<0> but was:<126>

[17:31:16] <temporalfox> with noah

[17:31:17] <temporalfox> ah

[17:31:18] <temporalfox> ./venv/bin/python: ./venv/bin/python: cannot execute binary file

[17:32:01] <temporalfox> it's because of OSX I think

[17:41:43] <purplefox> ok, so I guess you need to install linux on your macbook :)

[17:41:57] <purplefox> it will be much nicer anyway using a proper operating system ;)

[17:57:25] <temporalfox> purplefox why do we need to use a binary ? can't we use what the os provides natively ?

[17:59:58] <temporalfox> purplefox I whish I know linux better, but if I mention “leaning linux” in my weekly report and we deliver late, that won't do it :-)

[18:11:26] <purplefox> i suggest just commenting out the python test for now so you can run the test suite :)

[18:11:44] <purplefox> we should probably add something in there that checks the OS and only runs them if linux

[18:44:55] <temporalfox> purplefox ok, I don't know about linux, but osx comes out of the box with python

[18:45:10] <temporalfox> I'll try to run them with this one if osx

[18:45:48] <purplefox> i wouldn't get too hung up on running the python tests, getting the PR reviewed is probably more important ;)

[21:43:45] <andyhedges_> Hi, was just checking out the CORSHandler fix but vertx-web isn't compiling, should I post a issue?

[21:43:57] <andyhedges_> an*

[22:23:25] <purplefox> andyhedges_: hi andy, master should build now, there was an outstanding PR that I had to merge, but it should be ok now